Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document configuration generics #581

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

trevyn
Copy link
Contributor

@trevyn trevyn commented Sep 22, 2022

Closes #559

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 54.21% // Head: 55.66% // Increases project coverage by +1.45% 🎉

Coverage data is based on head (3630c2f) compared to base (92f4d00).
Patch has no changes to coverable lines.

❗ Current head 3630c2f differs from pull request most recent head e1c07f5. Consider uploading reports for the commit e1c07f5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk     #581      +/-   ##
==========================================
+ Coverage   54.21%   55.66%   +1.45%     
==========================================
  Files          50       50              
  Lines        4429     4313     -116     
==========================================
  Hits         2401     2401              
+ Misses       2028     1912     -116     
Impacted Files Coverage Δ
src/config.rs 82.60% <ø> (ø)
src/enc/impl_tuples.rs 100.00% <0.00%> (+69.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@VictorKoenders VictorKoenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@VictorKoenders VictorKoenders enabled auto-merge (squash) September 28, 2022 07:54
@VictorKoenders VictorKoenders merged commit 52464e0 into bincode-org:trunk Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixint et. al. are doc hidden but probably should be able to lookup
2 participants