Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Proposal: Check for biome config file on startup #274

Closed
wants to merge 5 commits into from

Conversation

simonorzel26
Copy link

Summary

This PR is a feature proposal that started with a "bug" or rather something I dislike with the biome plugin; enabling / disabling per workspace.

Unfortunately not every developer can migrate all legacy projects they have to biome so we are stuck with other linters/formatters, which when having the biome vscode plugin enabled, means errors showing on every project.

I propose a check for the biome.json /.jsonc file should be done per workspace and then disabled automatically as it would otherwise be useless and take up resources.

Obviously the long term answer is migrate everything to biome or ignore people who don't use biome, however achieving that goal imo is by broad support, and in this case making the extension less of a hassle to people maintaining many projects with different linters.

Description

Checks workspace for biome.json /.jsonc config file on plugin startup. Disables it with a message if not found.

Related Issue

Would fix this:
#74
or:
https://x.com/lilpropdrilla/status/1814578885683511329

This PR closes #<issue_number>

Checklist

  • I have tested my changes on the following platforms:
    • Windows
    • Linux
    • macOS

@nhedger
Copy link
Member

nhedger commented Jul 24, 2024

Hey 👋,

I appreciate you taking the time to put this together. We've received a lot of feedback about this, and it will actually be a part of v3 (#201). We'll be taking a slightly different approach, but the gist is you'll be able to enable/disable the extension at the workspace level and perhaps even at the folder level (think mono repo).

Relying only on the presence of the configuration file in a hard-coded way is not sufficient because users should still be able to use the extension even if they don't have a config file.

Again, thanks for your time here, but I'll close this PR since we're already on track to handle this case. Next time you plan to contribute to the extension (and I hope you do), please reach out via Discussions or Discord so we can give early feedback on ideas!

@nhedger nhedger closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants