Separate transaction details in funds views #6110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK. Looks good and makes those views more usable. As to your questions / doubts: I'd leave it as it is. These views are "info heavy" by design, they contain as much detail as possible to help the user categorize / search / document the entries. Therefore, removing columns seems counter-productive. Beautifying and re-arranging I don't think is necessary. |
ripcurlx
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
utACK - code changes are looking fine. utACK also based on #6110 (comment)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5308
Reserved view:
Locked view:
Transactions:
A few questions / doubts: