-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v1.9.8 #6482
Merged
Merged
Release/v1.9.8 #6482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update data stores for v1.9.7
Reduce number of blocks at GetBlocksResponse from 4000 to 3000 Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Left side is amount to burn to reach the max allowed receiver share based on the burned amount of all BM. The right side is the amount to burn to reach the max allowed receiver share based the boosted max burn target. Increase ISSUANCE_BOOST_FACTOR from 3 to 4. Add help overlay to burn target table header. Signed-off-by: HenrikJannsen <[email protected]>
… over-burned amount to the non capped candidates. This helps to avoid that the legacy BM would get the rest in case there are capped shares. It still can be that a candidate exceeds the cap and by the adjustment becomes capped. We take that into account and the legacy BM would get some share in that case. Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Refactoring: rename variables Signed-off-by: HenrikJannsen <[email protected]>
…CYCLE Adjust reimbursement amounts as we do not reimburse 100% of the DPT Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
…stributed BTC/BSQ Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
…RN_SHARE (taking into account potential increase due adjustment) Signed-off-by: HenrikJannsen <[email protected]>
We don't allow to get further back than 767950 (the block height from Dec. 18th 2022) Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Use AvailabilityResult.INVALID_SNAPSHOT_HEIGHT instead of AckMessage with error. Show description in error popup instead of enum name. Return PRICE_CHECK_FAILED instead of UNKNOWN_FAILURE at error at price check also for non api users. Signed-off-by: HenrikJannsen <[email protected]>
…dThreadPool The previously used newCachedThreadPool carries higher risk for execution exceptions if exceeded. Originally we had only one executor with a corePoolSize of 15 and a maximumPoolSize of 30 and queueCapacity was set to maximumPoolSize. This was risky when the 15 corePool threads have been busy and new messages or connection creation threads are queued up with potentially significant delay until getting served leading to timeouts. Now we use (if maxConnections is 12) corePoolSize of 24, maximumPoolSize 36 and queueCapacity 10. This gives considerable headroom. We also have split up the executors in 2 distinct ones. Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
This is required in finalize.sh script for creating the release bundle
#6480 reported reaching the limit with the current settings. Signed-off-by: HenrikJannsen <[email protected]>
bisq-github-admin-3
approved these changes
Dec 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - all commits were reviewed and are in master already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.