-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BM receive address selection #6700
Merged
alejandrogarcia83
merged 8 commits into
bisq-network:master
from
HenrikJannsen:fix-bm-receive-address-selection
May 23, 2023
Merged
Fix BM receive address selection #6700
alejandrogarcia83
merged 8 commits into
bisq-network:master
from
HenrikJannsen:fix-bm-receive-address-selection
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still keep the parameter as it will be reused later for the new bugfix Signed-off-by: HenrikJannsen <[email protected]>
…DATE, isHotfixActivated to isBugfix6699Activated, wasHotfixActivatedAtTradeDate to wasBugfix6699ActivatedAtTradeDate Signed-off-by: HenrikJannsen <[email protected]>
…when we use the custom address and when the change address. Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Implement new selection algorithm. Add methods for accessing the receiverAddress (not used yet, but will be used in next commits) Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
…n to make sure the old field is not used anymore from any client. Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
alvasw
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
alejandrogarcia83
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6699