Revert "net: do not advertise address where nobody is listening"

[hebasto]

This is a quick fix bitcoin-core/gui#567 which is assumed to be backported to 23.0rc3.

Effectively, this PR reverts #20769 which could be implemented later in a better way.

[fanquake]

I'm very ~0 on last-minute reverting bug fixes to bitcoind, to fix problems in the GUI.

[vasild]

I am a bit ~-0.1 on this. However, the problem is quite serious - bitcoin-qt just will refuse to start. Lets see if there would be better solution...

[maflcko]

I don't think there is anything wrong with reverting a hunk that was never released in a release

[hebasto]

I'm very ~0 on last-minute reverting bug fixes to bitcoind, to fix problems in the GUI.

In comparison the "bug" that had been fixed in #20769 with the bitcoin-core/gui#567, the latter looks much more seriously.

And, considering #20657 (comment):

Should we automatically set listenonion to 0 if listen is set to 0?

we already do in

bitcoin/src/init.cpp

Lines 688 to 689 in d6f225f

	if (args.SoftSetBoolArg("-listenonion", false))
	LogPrintf("%s: parameter interaction: -listen=0 -> setting -listenonion=0\n", __func__);

[vasild]

What about this:

--- i/src/qt/optionsmodel.cpp
+++ w/src/qt/optionsmodel.cpp
@@ -148,14 +148,17 @@ void OptionsModel::Init(bool resetSettings)
     if (!gArgs.SoftSetBoolArg("-natpmp", settings.value("fUseNatpmp").toBool())) {
         addOverriddenOption("-natpmp");
     }
 
     if (!settings.contains("fListen"))
         settings.setValue("fListen", DEFAULT_LISTEN);
-    if (!gArgs.SoftSetBoolArg("-listen", settings.value("fListen").toBool()))
+    if (!gArgs.SoftSetBoolArg("-listen", settings.value("fListen").toBool())) {
         addOverriddenOption("-listen");
+    } else if (!settings.value("fListen").toBool()) {
+        gArgs.SoftSetBoolArg("-listenonion", false);
+    }
 
     if (!settings.contains("server")) {
         settings.setValue("server", false);
     }
     if (!gArgs.SoftSetBoolArg("-server", settings.value("server").toBool())) {
         addOverriddenOption("-server");

It fixes bitcoin-core/gui#567 without reintroducing #20657.

[hebasto]

@vasild

What about this:

Mind submitting a PR in https://github.com/bitcoin-core/gui/pulls?

[vasild]

bitcoin-core/gui#568

[hebasto]

I'm very ~0 on last-minute reverting bug fixes to bitcoind, to fix problems in the GUI.

I am a bit ~-0.1 on this. However, the problem is quite serious - bitcoin-qt just will refuse to start. Lets see if there would be better solution...

Okay, closing in favor of bitcoin-core/gui#568.