Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken bumpfee method #42

Closed
wants to merge 1 commit into from
Closed

Fix broken bumpfee method #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,9 @@ pub enum OfflineWalletSubCommand {
/// TXID of the transaction to update
#[structopt(name = "TXID", short = "txid", long = "txid")]
txid: String,
#[structopt(name = "CHANGE_VOUT", long = "vout")]
/// Change output index to reduce it's amount in order to bump fee
change_vout: u32,
/// Allows the wallet to reduce the amount of the only output in order to increase fees. This is generally the expected behavior for transactions originally created with `send_all`
#[structopt(short = "all", long = "send_all")]
send_all: bool,
Expand Down Expand Up @@ -847,6 +850,7 @@ where
}
BumpFee {
txid,
change_vout,
send_all,
offline_signer,
utxos,
Expand All @@ -855,12 +859,17 @@ where
} => {
let txid = Txid::from_str(txid.as_str()).map_err(|s| Error::Generic(s.to_string()))?;

let outpoint = OutPoint::new(txid, change_vout);
let script_pubkey = match wallet.get_utxo(outpoint) {
Ok(Some(utxo)) => utxo.txout.script_pubkey,
_ => return Err(Error::UnknownUtxo),
};

let mut tx_builder = wallet.build_fee_bump(txid)?;
tx_builder.fee_rate(FeeRate::from_sat_per_vb(fee_rate));

if send_all {
// TODO: Find a way to get the recipient scriptpubkey to allow shrinking
//tx_builder.allow_shrinking()
tx_builder.allow_shrinking(script_pubkey)?;
}

if offline_signer {
Expand Down