Un-pin fd-lock version #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
notmandatory
force-pushed
the
unpin-fd-lock
branch
from
9131f73 to
8fca9ae
Compare
notmandatory
force-pushed
the
unpin-fd-lock
branch
from
8ed2395 to
7a62885
Compare
MSRV issue with fd-lock 3.0.1 was fixed with version 3.0.2. See: yoshuawuyts/fd-lock#16
This is required because rustyline 9.1.0 uses rust edition 2021 which this project has not yet adopted. See: kkawakam/rustyline#570
notmandatory
force-pushed
the
unpin-fd-lock
branch
from
7a62885 to
40a0138
Compare
|
rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MSRV issue with fd-lock 3.0.1 was fixed with version 3.0.2. See: yoshuawuyts/fd-lock#16
But now I had to limit the rustyline version to <9.1.0 because that version upgrades to rust edition 2021 which we haven't adopted yet and would change our MSRV to 1.56.0.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing