Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-pin fd-lock version #64

Merged
merged 2 commits into from
Dec 12, 2021

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Dec 9, 2021

Description

MSRV issue with fd-lock 3.0.1 was fixed with version 3.0.2. See: yoshuawuyts/fd-lock#16

But now I had to limit the rustyline version to <9.1.0 because that version upgrades to rust edition 2021 which we haven't adopted yet and would change our MSRV to 1.56.0.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory marked this pull request as draft December 10, 2021 02:45
@notmandatory notmandatory marked this pull request as ready for review December 10, 2021 04:30
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 7a62885

MSRV issue with fd-lock 3.0.1 was fixed with version 3.0.2. See:
yoshuawuyts/fd-lock#16
This is required because rustyline 9.1.0 uses rust edition 2021 which
this project has not yet adopted. See:
kkawakam/rustyline#570
@notmandatory
Copy link
Member Author

rebased.

@notmandatory notmandatory merged commit 40a0138 into bitcoindevkit:master Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants