Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump project MSRV to 1.57.0 #842

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Bump project MSRV to 1.57.0 #842

merged 1 commit into from
Jan 27, 2023

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Jan 24, 2023 •
edited
Loading

Description

Bump project MSRV from 1.56.1 to 1.57.0.

Also bumped the check-wasm and test_hardware_wallet jobs rust STABLE version to 1.65.0 to match other jobs.

Notes to the reviewers

The rustls crate changed their MSRV to 1.57 on 2023-01-12 with a patch release from 0.20.7 to 0.20.8, rustls/rustls#1152. This breaks our CI builds that use esplora-client 0.3 because it depends on a version of ureq that uses the latest rustls.

rustls v0.20.8
└── ureq v2.6.2
    └── esplora-client v0.3.0
        └── bdk v0.26.0 (/Users/steve/git/notmandatory/bdk)
    [build-dependencies]
    └── electrsd v0.21.1
        [dev-dependencies]
        └── bdk v0.26.0 (/Users/steve/git/notmandatory/bdk)

https://github.com/rustls/rustls/blob/main/README.md

Changelog notice

Project MSRV changed from 1.56.1 to 1.57.0.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Jan 24, 2023
@notmandatory
Copy link
Member Author

I'm favoring this option since MSRVs and dependencies will change anyway when we get the bdk_core stuff out with 1.0 and any projects using bdk that require MSRV 1.56.1 can stay on version bdk 0.26.

This was referenced Jan 24, 2023
Merged
Closed
Merged
Merged
w0xlt
w0xlt reviewed Jan 26, 2023
View reviewed changes
Copy link
Contributor

@w0xlt w0xlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

vladimirfomene
vladimirfomene approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@vladimirfomene vladimirfomene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a6d3823

rajarshimaitra
rajarshimaitra approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a6d3823

@notmandatory notmandatory merged commit 2e7a220 into bitcoindevkit:master Jan 27, 2023
This was referenced Jan 30, 2023
Merged
Merged
notmandatory added a commit that referenced this pull request Feb 2, 2023
@notmandatory
Merge #847: Update electrsd to version 0.22
46273fe 
147a4ed Update electrsd to version 0.22 (Steve Myers)

Pull request description:

  ### Description

  Update `electrsd` dev-dependency to version `0.22`.

  ### Notes to the reviewers

  We're able to do this now that esplora was updated in #830 and our MSRV was bumped to `1.57.0` in #842.

  ### Changelog

  None.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  rajarshimaitra:
    ACK 147a4ed

Tree-SHA512: 20e0aebb02d786a4d426a2d2e66b78225a803eee2c2f6092b0cf8f18e6fe91e37ef7a74e109e3ad4d734af8de4dc71598f7e80f50d40187442dad323000c6090
This was referenced Feb 2, 2023
Closed
Closed
@notmandatory
Copy link
Member Author

We're planning to move MSRV down as soon as we can find replacements or test version or features re-configs for the dependencies that are causing us to move up. See #331 for some preliminary analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0xlt w0xlt w0xlt left review comments

@vladimirfomene vladimirfomene vladimirfomene approved these changes

@rajarshimaitra rajarshimaitra rajarshimaitra approved these changes

Assignees

@notmandatory notmandatory

Labels
ci
Projects
None yet
Milestone
Release 0.27.0 Feature Freeze
Development

Successfully merging this pull request may close these issues.
4 participants
@notmandatory @vladimirfomene @rajarshimaitra @w0xlt