Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add introduction for bdk-cli #85

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

rajarshimaitra
Copy link
Contributor

Added a small introduction for bdk-cli. This is intended to be placed before the installation instruction.

@netlify
Copy link

netlify bot commented Jan 4, 2022

Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit 5e43d6b
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/62d609a01b51aa000997a629
😎 Deploy Preview https://deploy-preview-85--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rajarshimaitra
Copy link
Contributor Author

@ConorOkus The added page doesn't seem to be appearing in the local build of the website. Do I have to do something extra to include the Introduction page?

@ConorOkus
Copy link
Collaborator

Nice one @rajarshimaitra, yeah you'll need to add a link in the ./vuepress/config.js file

@rajarshimaitra
Copy link
Contributor Author

Thanks for the look @ConorOkus

Updated and added the page.

@rajarshimaitra
Copy link
Contributor Author

Updated with suggestions.

@ConorOkus
Copy link
Collaborator

LGTM

@rajarshimaitra
Copy link
Contributor Author

@notmandatory This one is clear from my side.

@notmandatory
Copy link
Member

LGTM will put it in as soon as we get bitcoindevkit/bdk-cli#65 merged so the auto deployed regtest node part works.

@notmandatory
Copy link
Member

Looks like this one is ready to go but needs a final rebase. Sorry for the long delay!

@notmandatory notmandatory merged commit 5e43d6b into bitcoindevkit:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants