Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture Ctrl+C in cli_wallet when not in daemon mode #1193

Closed
6 of 10 tasks
abitmore opened this issue Jul 27, 2018 · 10 comments
Closed
6 of 10 tasks

Capture Ctrl+C in cli_wallet when not in daemon mode #1193

abitmore opened this issue Jul 27, 2018 · 10 comments
Assignees
@cogutvalera
Labels
cli feature security
Milestone
201902 - Feature ...

Comments

@abitmore
Copy link
Member

abitmore commented Jul 27, 2018 •
edited by ryanRfox
Loading

When a cli_wallet process is not running in daemon mode (not stared with--daemon), if Ctrl+C is pressed, it will exit uncleanly, which is dangerous because it may cause loss of unsaved private keys.

IMHO we should save wallet file before shutting down.

By the way, Ctrl+C was the only option for Windows users to exit from cli_wallet. Now we've added a quit command in #1104, so Windows users can exit normally now. Linux and MacOS users can already exit from cli_wallet by pressing Ctrl+D, now they can use the quit command as well.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
    • Assigned: @cogutvalera
    • Estimated: 7 hours
      • Original implementation, merged, reverted: 3 hours (paid Core Team - Weeks 30-31)
      • Bugfix/refactoring: 4 hours (paid Core Team - Weeks 30-31)
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added the cli label Jul 27, 2018
@cogutvalera
Copy link
Member

cogutvalera commented Jul 30, 2018 •
edited
Loading

Next code doesn't capture CTRL+C also:

  1. https://github.com/bitshares/bitshares-core/blob/develop/programs/cli_wallet/main.cpp#L286-L289
  2. https://github.com/bitshares/bitshares-core/blob/develop/programs/delayed_node/main.cpp#L172-L175
  3. https://github.com/bitshares/bitshares-core/blob/develop/programs/witness_node/main.cpp#L254-L259

I will create new issue for all them, right ?

@cogutvalera cogutvalera mentioned this issue Jul 30, 2018
Closed
17 tasks
@cogutvalera
Copy link
Member

cogutvalera commented Jul 30, 2018 •
edited
Loading

I want to claim this issue, my estimation/approximation for this issue is about 3 hours

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Jul 30, 2018
@cogutvalera
Capture Ctrl+C in cli_wallet when not in daemon mode bitshares#1193
ae51f4c
@cogutvalera cogutvalera mentioned this issue Jul 30, 2018
Merged
@cogutvalera cogutvalera mentioned this issue Jul 30, 2018
Merged
@cogutvalera
Copy link
Member

Thanks for assigning this issue to me !

@cogutvalera cogutvalera mentioned this issue Jul 30, 2018
Merged
abitmore added a commit that referenced this issue Jul 30, 2018
@abitmore
Merge pull request #1207 from cogutvalera/valera_issue_1193
09f2d0d 
Capture Ctrl+C in cli_wallet when not in daemon mode #1193
@abitmore
Copy link
Member Author

Fixed by #1207.

@abitmore
Copy link
Member Author

I want to claim this issue, my estimation/approximation for this issue is about 3 hours

Looks good to me. Thanks. Pinging @ryanRfox.

@cogutvalera
Copy link
Member

Thank you very much !

@ryanRfox
Copy link
Contributor

Assigned @cogutvalera and estimated 3 hours.

@cogutvalera
Copy link
Member

Thanks !

@cogutvalera cogutvalera mentioned this issue Aug 1, 2018
Closed
8 tasks
abitmore added a commit that referenced this issue Aug 2, 2018
@abitmore
Revert "Capture Ctrl+C in cli_wallet when not in daemon mode #1193"
d59f1dc
abitmore added a commit that referenced this issue Aug 2, 2018
@abitmore
Merge pull request #1220 from bitshares/revert-1207-valera_issue_1193
d04b09c 
Revert "Capture Ctrl+C in cli_wallet when not in daemon mode #1193"
@pmconrad
Copy link
Contributor

pmconrad commented Aug 2, 2018

Reopened because #1220 reverts the solution. @cogutvalera please close #1218 and provide a new solution for this issue.

@pmconrad pmconrad reopened this Aug 2, 2018
@pmconrad pmconrad mentioned this issue Aug 2, 2018
Closed
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Aug 3, 2018
@cogutvalera
Capture Ctrl+C in cli_wallet when not in daemon mode bitshares#1193
46ca535
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Aug 3, 2018
@cogutvalera
Capture Ctrl+C in cli_wallet when not in daemon mode bitshares#1193
033ee7c
@cogutvalera cogutvalera mentioned this issue Aug 3, 2018
Merged
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Aug 10, 2018
@cogutvalera
capture SIGINT and SIGTERM for cli_wallet when not in daemon mode bit…
2f45952 
…shares#1193
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Sep 28, 2018
@cogutvalera
Capture Ctrl+C in cli_wallet when not in daemon mode bitshares#1193
29b733d
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Sep 28, 2018
@cogutvalera
capture SIGINT and SIGTERM for cli_wallet when not in daemon mode bit…
f8cca70 
…shares#1193
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Sep 28, 2018
@cogutvalera
Capture Ctrl+C in cli_wallet when not in daemon mode bitshares#1193
bed035f
@cogutvalera cogutvalera mentioned this issue Sep 28, 2018
Closed
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018
@cogutvalera
Capture Ctrl+C in cli_wallet when not in daemon mode bitshares#1193 -…
69eb872 
… fclose(stdin) solution
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018
@cogutvalera
Capture Ctrl+C in cli_wallet when not in daemon mode bitshares#1193
e2eecfb
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018
@cogutvalera
capture SIGINT and SIGTERM for cli_wallet when not in daemon mode bit…
fc762a4 
…shares#1193
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018
@cogutvalera
Capture Ctrl+C in cli_wallet when not in daemon mode bitshares#1193
ad21932
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018
@cogutvalera
Capture Ctrl+C in cli_wallet when not in daemon mode bitshares#1193 -…
e4b59b7 
… fclose(stdin) solution
cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018
@cogutvalera
Capture Ctrl+C in cli_wallet when not in daemon mode bitshares#1193
7dc0de7
pmconrad added a commit that referenced this issue Oct 20, 2018
@pmconrad
Merge pull request #1232 from cogutvalera/issue_1193
0eebc1e 
Capture Ctrl+C in cli_wallet when not in daemon mode #1193
@pmconrad
Copy link
Contributor

Resolved with #1232

@pmconrad pmconrad mentioned this issue Dec 21, 2018
Merged
@MichelSantos MichelSantos mentioned this issue Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cogutvalera cogutvalera

Labels
cli feature security
Projects
None yet
Milestone
201902 - Feature Release
Development

No branches or pull requests
4 participants
@pmconrad @abitmore @ryanRfox @cogutvalera