Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18100] Add mlock and memfd_secret implementations #125

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dani-garcia
Copy link
Member

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Logo
Checkmarx One – Scan Summary & Detailsef2f96a1-6353-4b8b-951a-e832b2f98fc1

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 98.85434% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.14%. Comparing base (6008e90) to head (3bf0b24).

Files with missing lines Patch % Lines
...c/store/backend/implementation/custom_slice/mod.rs 98.67% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   65.91%   67.14%   +1.23%     
==========================================
  Files         196      197       +1     
  Lines       15333    15920     +587     
==========================================
+ Hits        10106    10689     +583     
- Misses       5227     5231       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia force-pushed the ps/secure-crypto-service-backends branch from e4906dc to 0aa0b89 Compare January 21, 2025 18:27
Base automatically changed from ps/secure-crypto-service to main February 3, 2025 17:55
@dani-garcia dani-garcia force-pushed the ps/secure-crypto-service-backends branch from 0aa0b89 to c52afa4 Compare February 3, 2025 17:57
@dani-garcia dani-garcia changed the title Add mlock and memfd_secret implementations [PM-18100] Add mlock and memfd_secret implementations Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant