Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename rem to mod_op to match EVM opcode #2187

Closed
wants to merge 2 commits into from
Closed

refactor: rename rem to mod_op to match EVM opcode #2187

wants to merge 2 commits into from
+2 −2

Conversation

crStiv
Copy link

@crStiv crStiv commented Mar 11, 2025

Rename arithmetic::rem function to mod_op to better align with the MOD opcode name in EVM.

Changes:

  • Rename rem -> mod_op in arithmetic.rs
  • Update corresponding reference in instruction table

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 11, 2025

CodSpeed Performance Report

Merging #2187 will not alter performance

Comparing crStiv:rsrsrs (aa90097) with main (f11bbab)

Summary

✅ 8 untouched benchmarks

@rakita
Copy link
Member

rakita commented Mar 11, 2025

rem is fine for now

@rakita rakita closed this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crStiv @rakita