Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appview: permit redirects during blob resolution #3370

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

devinivy
Copy link
Collaborator

Followup to changes in #3177, ensure we still follow redirects during blob resolution.

Copy link
Contributor

@matthieusieben matthieusieben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, This seems like the way to go !

@devinivy devinivy merged commit c6c8686 into main Jan 15, 2025
10 checks passed
@devinivy devinivy deleted the divy/appview-blob-redirects branch January 15, 2025 16:04
@snarfed
Copy link
Contributor

snarfed commented Jan 15, 2025

Thanks @devinivy! Looks like this hit Bridgy Fed too, we redirect getBlob requests too, and our images stopped working some time last night. Definitely looking forward to seeing this deployed!

@devinivy
Copy link
Collaborator Author

It was deployed today, should be resolved!

@snarfed
Copy link
Contributor

snarfed commented Jan 16, 2025

Woo, thank you! Confirmed, Bridgy Fed's images are working now.

@snarfed
Copy link
Contributor

snarfed commented Jan 16, 2025

@devinivy just fyi I got a report of a specific account whose images still aren't working, https://bsky.app/profile/mattdsteele.carhenge.club.ap.brid.gy . Blobs in the records seem to be fine, we're serving getBlob 301 redirects like normal. Oddly their videos are still up and working ok in bsky.app, which is surprising. The images and videos are all on S3, served directly from s3-us-east-2.amazonaws.com URLs.

Examples: https://pdsls.dev/at/did:plc:ptr3w7zzvw4fo6vdra3gjprn/app.bsky.feed.post/3lfsyvwyu3cu2 (broken image), https://pdsls.dev/at/did:plc:ptr3w7zzvw4fo6vdra3gjprn/app.bsky.feed.post/3lflnkn65fgz2 (ok video)

cc @mattdsteele

@devinivy
Copy link
Collaborator Author

With #3379 I think we're good to go— @snarfed appreciate your patience as we ironed this out!

@snarfed
Copy link
Contributor

snarfed commented Jan 17, 2025

@devinivy totally ok, thanks for the quick fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants