Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase route #948

Merged
merged 5 commits into from
May 9, 2023
Merged

Rebase route #948

merged 5 commits into from
May 9, 2023

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented May 1, 2023

Adds a route to perform rebases

Also:

  • cleans up some rebase logic a bit (avoids join)
  • avoids lock contention on rebases similarly to recent commit work

@dholms dholms marked this pull request as ready for review May 2, 2023 00:22
const repo = await Repo.load(storage, currRoot)
const rebaseData = await repo.formatRebase(this.repoSigningKey)

// rebases are expensive & should be done rarely, we don't try to re-process on concurrent writes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firm but fair 👍

Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@dholms dholms merged commit b20a504 into main May 9, 2023
@dholms dholms deleted the rebase-route branch May 9, 2023 10:54
mloar pushed a commit to mloar/atproto that referenced this pull request Sep 26, 2023
* tidy rebase query

* add rebase route

* bring tests up to speed

* add tx check
mloar pushed a commit to mloar/atproto that referenced this pull request Nov 15, 2023
* tidy rebase query

* add rebase route

* bring tests up to speed

* add tx check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants