Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Japanese translation #3656

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Update Japanese translation #3656

merged 8 commits into from
Apr 23, 2024

Conversation

tkusano
Copy link
Contributor

@tkusano tkusano commented Apr 23, 2024

  • GIPHY is replaced by Tenor
    • 'featured GIFs' is translated as "おすすめのGIF" on Tenor website (Japanese version).
  • Accessibility hint for long-pressing hashtags have been changed to follow

tkusano added 3 commits April 23, 2024 10:57
@tkusano
Update Japanese translation
20799b3 
- GIPHY is replaced by Tenor
- Accessibility hint for long-pressing hashtags have been changed to follow
@tkusano
Merge branch 'main' into ja-translation-4
053e652
@tkusano
Translated accessibility hints related to embedded GIFs
800553f
@tkusano
Copy link
Contributor Author

tkusano commented Apr 23, 2024

@Hima-Zinn @dolciss @oboenikui @noritada @middlingphys @hibiki @reindex-ot @haoyayoi @vyv03354

Japanese translation is updated to sync with main.
(GIPHY -> Tenor, embed GIF player related a11y hints)

@tkusano
Copy link
Contributor Author

tkusano commented Apr 23, 2024

  • Translated "2FA" as 「２要素認証」（2FA/Two-Factor Authentication を「２要素認証」と訳しました） 0f3a2d6

settings-2fa-column
disable-2fa-dialog

Hima-Zinn
Hima-Zinn reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@Hima-Zinn Hima-Zinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented on a few points of concern and would appreciate corrections if necessary.

@tkusano
Copy link
Contributor Author

tkusano commented Apr 23, 2024

Translation modified to reflect Hima-Zinn's comments.

@tkusano
Copy link
Contributor Author

tkusano commented Apr 23, 2024

Now, ready to merge into main

pfrazee
pfrazee approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks everyone!

@pfrazee pfrazee merged commit dc3f694 into bluesky-social:main Apr 23, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request Apr 23, 2024
@estrattonbailey
Merge remote-tracking branch 'origin/main' into halo/base
a386e4d 
* origin/main: (47 commits)
  Add option to remove quoted post in composer (#3670)
  Add border radius to GIF loading state (#3669)
  use mp4 over webm (#3666)
  Release 1.79 (#3661)
  Update Japanese translation (#3656)
  [Statsig] Add test gates and events (#3659)
  Quick fix to ensure disable 2fa dialog adjusts to keyboard (#3658)
  Email auth factor (#3602)
  GIF Viewer (#3605)
  Ungate profile scroll fix (#3655)
  rm country param (#3653)
  [GIFs] Remove consent flow (#3652)
  [GIFs] Replace GIPHY with Tenor (#3651)
  properly close the switch account dialog (#3558)
  [GIFs] Reset scroll on query change (#3642)
  Update French translations (#3644)
  [GIFs] Add error boundary to GIF picker (#3643)
  Revert "Add layout transitions to the composer photo gallery on iOS (#3609)" (#3649)
  Update Finnish translations  (#3630)
  Update Japanese translations (#3632)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hima-Zinn Hima-Zinn Hima-Zinn left review comments

@pfrazee pfrazee pfrazee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkusano @pfrazee @Hima-Zinn