Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

390 refactoring validations in link and helper link routes with express validator #448

Merged
merged 11 commits into from
Jan 2, 2025
Merged

390 refactoring validations in link and helper link routes with express validator #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
43a87d4
feat: add validations to link
DeboraSerra Dec 30, 2024
f9f848c
feat: pass validations to route and clean controller
DeboraSerra Dec 30, 2024
88ea1da
chore: update postman requests
DeboraSerra Dec 30, 2024
9748d7c
feat: create helper link validations
DeboraSerra Dec 30, 2024
e1f6a30
feat: pass validations to route and clean controller
DeboraSerra Dec 30, 2024
138787e
chore: update postman requests
DeboraSerra Dec 30, 2024
f074815
test: fix tests to new validations
DeboraSerra Dec 30, 2024
26dd257
fix: add coderabbit fixes
DeboraSerra Dec 30, 2024
9e81bbd
fix: remove unused functions from helperLink
DeboraSerra Dec 30, 2024
a9496b0
fix: change error treatment on link
DeboraSerra Dec 31, 2024
3261688
Merge branch 'develop' of github.com:bluewave-labs/bluewave-onboardin…
DeboraSerra Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions backend/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
import globals from "globals";
import pluginJs from "@eslint/js";

import pluginJs from '@eslint/js';
import globals from 'globals';

/** @type {import('eslint').Linter.Config[]} */
export default [
{files: ["**/*.js"], languageOptions: {sourceType: "commonjs"}},
{languageOptions: { globals: globals.node }},
{
files: ['**/*.js'],
languageOptions: { sourceType: 'commonjs' },
rules: { 'no-unused-vars': ['warn', { destructuredArrayIgnorePattern: '^_', ignoreRestSiblings: true }] },
},
{ languageOptions: { globals: globals.node } },
pluginJs.configs.recommended,
];
];
120 changes: 105 additions & 15 deletions backend/postman/HelperLinks.postman_collection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"bearer": [
{
"key": "token",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJqaG9uLmRvZUBlbWFpbC5jb20iLCJpYXQiOjE3MzAyNTY2ODgsImV4cCI6MTczMDI2MDI4OH0.pzV9pcXrfIbzA38Uwp8fO_UEms25SJniAlrhM83lIsE",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJyZW11bWVrdUBtYWlsaW5hdG9yLmNvbSIsImlhdCI6MTczNTU4MDY2NiwiZXhwIjoxNzM1NTg0MjY2fQ.NIzkEJEP7-Ns46WRR9PH2YzxS-9gA3cpyWYyuzzOQRE",
"type": "string"
}
]
Expand Down Expand Up @@ -91,6 +91,91 @@
},
"response": []
},
{
"name": "Get helpers with link",
"request": {
"auth": {
"type": "bearer",
"bearer": [
{
"key": "token",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJyZW11bWVrdUBtYWlsaW5hdG9yLmNvbSIsImlhdCI6MTczNTU4MDY2NiwiZXhwIjoxNzM1NTg0MjY2fQ.NIzkEJEP7-Ns46WRR9PH2YzxS-9gA3cpyWYyuzzOQRE",
"type": "string"
}
]
},
"method": "GET",
"header": [
{
"key": "Authorization",
"value": "Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJuZXdfdXNlcjFAZXhhbXBsZS5jb20iLCJpYXQiOjE3Mjc0NjI3NTUsImV4cCI6MTcyNzQ2NjM1NX0.yD0DL-LDFC7O-jgLI_eSHtJw2L1AttsnPv8lOzGzNRw",
"name": "authorization",
"type": "text"
},
{
"key": "Cache-Control",
"value": "no-cache",
"name": "cache-control",
"type": "text"
},
{
"key": "Postman-Token",
"value": "<calculated when request is sent>",
"name": "postman-token",
"type": "text"
},
{
"key": "Host",
"value": "<calculated when request is sent>",
"name": "host",
"type": "text"
},
{
"key": "User-Agent",
"value": "PostmanRuntime/7.39.1",
"name": "user-agent",
"type": "text"
},
{
"key": "Accept",
"value": "*/*",
"name": "accept",
"type": "text"
},
{
"key": "Accept-Encoding",
"value": "gzip, deflate, br",
"name": "accept-encoding",
"type": "text"
},
{
"key": "Connection",
"value": "keep-alive",
"name": "connection",
"type": "text"
},
{
"key": "content-length",
"value": "1024",
"type": "text"
}
],
"url": {
"raw": "http://localhost:3000/api/helper-link/get_helpers_with_links",
"protocol": "http",
"host": [
"localhost"
],
"port": "3000",
"path": [
"api",
"helper-link",
"get_helpers_with_links"
]
}
},
"response": []
},
{
"name": "Get by user Id",
"request": {
Expand All @@ -99,7 +184,7 @@
"bearer": [
{
"key": "token",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJqaG9uLmRvZUBlbWFpbC5jb20iLCJpYXQiOjE3MzAyNTc1NjAsImV4cCI6MTczMDI2MTE2MH0.hdD0gV84Ol-LIgeX5jaJI6rCZJ_dDHzD2hFGgFhxhkc",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJyZW11bWVrdUBtYWlsaW5hdG9yLmNvbSIsImlhdCI6MTczNTU4MDY2NiwiZXhwIjoxNzM1NTg0MjY2fQ.NIzkEJEP7-Ns46WRR9PH2YzxS-9gA3cpyWYyuzzOQRE",
"type": "string"
}
]
Expand Down Expand Up @@ -161,15 +246,16 @@
}
],
"url": {
"raw": "http://localhost:3000/api/helper-link",
"raw": "http://localhost:3000/api/helper-link/get_helpers",
"protocol": "http",
"host": [
"localhost"
],
"port": "3000",
"path": [
"api",
"helper-link"
"helper-link",
"get_helpers"
]
}
},
Expand All @@ -183,7 +269,7 @@
"bearer": [
{
"key": "token",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJqaG9uLmRvZUBlbWFpbC5jb20iLCJpYXQiOjE3MzAyNTc1NjAsImV4cCI6MTczMDI2MTE2MH0.hdD0gV84Ol-LIgeX5jaJI6rCZJ_dDHzD2hFGgFhxhkc",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJyZW11bWVrdUBtYWlsaW5hdG9yLmNvbSIsImlhdCI6MTczNTU4MDY2NiwiZXhwIjoxNzM1NTg0MjY2fQ.NIzkEJEP7-Ns46WRR9PH2YzxS-9gA3cpyWYyuzzOQRE",
"type": "string"
}
]
Expand Down Expand Up @@ -252,23 +338,24 @@
],
"body": {
"mode": "raw",
"raw": "{\r\n \"title\": \"Help Center\",\r\n \"headerBackgroundColor\": \"#ffffff\", \r\n \"linkFontColor\": \"#000000\",\r\n \"iconColor\": \"#000000\"\r\n}",
"raw": "{\r\n \"title\": \"Help Center\",\r\n \"headerBackgroundColor\": \"#ffffff\",\r\n \"linkFontColor\": \"#000000\",\r\n \"iconColor\": \"#000000\",\r\n \"links\": [\r\n {\r\n \"title\": \"link1\",\r\n \"url\": \"https://bluewavelabs.ca\"\r\n },\r\n {\r\n \"title\": \"link2\",\r\n \"url\": \"https://bluewavelabs.ca\"\r\n }\r\n ]\r\n}",
"options": {
"raw": {
"language": "json"
}
}
},
"url": {
"raw": "http://localhost:3000/api/helper-link",
"raw": "http://localhost:3000/api/helper-link/add_helper",
"protocol": "http",
"host": [
"localhost"
],
"port": "3000",
"path": [
"api",
"helper-link"
"helper-link",
"add_helper"
]
}
},
Expand All @@ -282,7 +369,7 @@
"bearer": [
{
"key": "token",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJqaG9uLmRvZUBlbWFpbC5jb20iLCJpYXQiOjE3MzAyNTc1NjAsImV4cCI6MTczMDI2MTE2MH0.hdD0gV84Ol-LIgeX5jaJI6rCZJ_dDHzD2hFGgFhxhkc",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJyZW11bWVrdUBtYWlsaW5hdG9yLmNvbSIsImlhdCI6MTczNTU4MDY2NiwiZXhwIjoxNzM1NTg0MjY2fQ.NIzkEJEP7-Ns46WRR9PH2YzxS-9gA3cpyWYyuzzOQRE",
"type": "string"
}
]
Expand Down Expand Up @@ -344,7 +431,7 @@
}
],
"url": {
"raw": "http://localhost:3000/api/helper-link/1",
"raw": "http://localhost:3000/api/helper-link/get_helper/1",
"protocol": "http",
"host": [
"localhost"
Expand All @@ -353,6 +440,7 @@
"path": [
"api",
"helper-link",
"get_helper",
"1"
]
}
Expand All @@ -367,7 +455,7 @@
"bearer": [
{
"key": "token",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJqaG9uLmRvZUBlbWFpbC5jb20iLCJpYXQiOjE3MzAyNTc1NjAsImV4cCI6MTczMDI2MTE2MH0.hdD0gV84Ol-LIgeX5jaJI6rCZJ_dDHzD2hFGgFhxhkc",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJyZW11bWVrdUBtYWlsaW5hdG9yLmNvbSIsImlhdCI6MTczNTU4MDY2NiwiZXhwIjoxNzM1NTg0MjY2fQ.NIzkEJEP7-Ns46WRR9PH2YzxS-9gA3cpyWYyuzzOQRE",
"type": "string"
}
]
Expand All @@ -376,15 +464,15 @@
"header": [],
"body": {
"mode": "raw",
"raw": "{\r\n \"title\": \"Help center\",\r\n \"headerBackgroundColor\": \"#ffffff\", \r\n \"linkFontColor\": \"#000000\",\r\n \"iconColor\": \"#000000\",\r\n \"userId\": 1\r\n}",
"raw": "{\r\n \"title\": \"Help center\",\r\n \"headerBackgroundColor\": \"#ffffff\",\r\n \"linkFontColor\": \"#000000\",\r\n \"iconColor\": \"#000000\",\r\n \"userId\": 1,\r\n \"links\": []\r\n}",
"options": {
"raw": {
"language": "json"
}
}
},
"url": {
"raw": "http://localhost:3000/api/helper-link/1",
"raw": "http://localhost:3000/api/helper-link/edit_helper/1",
"protocol": "http",
"host": [
"localhost"
Expand All @@ -393,6 +481,7 @@
"path": [
"api",
"helper-link",
"edit_helper",
"1"
]
}
Expand All @@ -407,7 +496,7 @@
"bearer": [
{
"key": "token",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJqaG9uLmRvZUBlbWFpbC5jb20iLCJpYXQiOjE3MzAyNTc1NjAsImV4cCI6MTczMDI2MTE2MH0.hdD0gV84Ol-LIgeX5jaJI6rCZJ_dDHzD2hFGgFhxhkc",
"value": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJyZW11bWVrdUBtYWlsaW5hdG9yLmNvbSIsImlhdCI6MTczNTU4MDY2NiwiZXhwIjoxNzM1NTg0MjY2fQ.NIzkEJEP7-Ns46WRR9PH2YzxS-9gA3cpyWYyuzzOQRE",
"type": "string"
}
]
Expand Down Expand Up @@ -463,7 +552,7 @@
}
],
"url": {
"raw": "http://localhost:3000/api/helper-link/1",
"raw": "http://localhost:3000/api/helper-link/delete_helper/1",
"protocol": "http",
"host": [
"localhost"
Expand All @@ -472,6 +561,7 @@
"path": [
"api",
"helper-link",
"delete_helper",
"1"
]
}
Expand Down
Loading
Loading