Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep profile section sticky inside sidebar #565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasneetsingh6114
Copy link

@jasneetsingh6114 jasneetsingh6114 commented Mar 8, 2025

Describe your changes

Briefly describe the changes you made and their purpose.

Issue number

Mention the issue number(s) this PR addresses #557

Please ensure all items are checked off before requesting a review:

  • I deployed the code locally.
  • I have performed a self-review of my code.
  • I have included the issue # in the PR.
  • I have labelled the PR correctly.
  • The issue I am working on is assigned to me.
  • I didn't use any hardcoded values (otherwise it will not scale, and will make it difficult to maintain consistency across the application).
  • I made sure font sizes, color choices etc are all referenced from the theme.
  • My PR is granular and targeted to one specific feature.
  • I took a screenshot or a video and attached to this PR if there is a UI change.
Screen.Recording.2025-03-08.151107.mp4

Copy link
Contributor

coderabbitai bot commented Mar 8, 2025

Walkthrough

A new CSS property, overflow-y: auto;, was added to the .sidebar class to allow vertical scrolling when content exceeds the container height. Additionally, the .user-info class in another CSS module was updated by changing its position from relative to sticky, removing explicit display and alignment properties, and consolidating individual padding values into a shorthand property. There were no modifications to exported or public entities.

Changes

Files Change Summary
frontend/src/.../LogoStyles.module.css Added overflow-y: auto; to the .sidebar class to ensure vertical overflow content is scrollable.
frontend/src/.../UserProfileSidebar.module.css Updated .user-info class by changing position from relative to sticky, removing display, align-items, and justify-content, and consolidating padding.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14e2bbc and 091c7de.

📒 Files selected for processing (2)
  • frontend/src/components/Logo/LogoStyles.module.css (1 hunks)
  • frontend/src/components/UserProfileSidebar/UserProfileSidebar.module.css (1 hunks)
🔇 Additional comments (2)
frontend/src/components/Logo/LogoStyles.module.css (1)

29-29: Energetic Scroll Magic!

The addition of overflow-y: auto; on the .sidebar class at line 29 skillfully enables vertical scrolling when content exceeds the container’s height. This change is as smooth as a well-delivered verse, ensuring that the sidebar remains functional and accessible even during heavy scrolling. Great work keeping it all in flow!

frontend/src/components/UserProfileSidebar/UserProfileSidebar.module.css (1)

2-4: Live and Sticky in the House!

Changing the .user-info class to use position: sticky; and setting bottom: 0; is a smart move that keeps the profile section in view during scrolling—just like a headline act that never misses a beat. The streamlined padding (1rem 16px;) gives it a clean, unified look. This adjustment should make the sidebar profile feel as dependable as your favourite jam!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Owaiseimdad
Copy link

@jasneetsingh6114 I have made some changes in the same file, and pr is also raised. Let get this merged after than Also we can avoid using the padding for user-info. Have defined a way for it.

@erenfn
Copy link
Collaborator

erenfn commented Mar 11, 2025

@jasneetsingh6114 I have made some changes in the same file, and pr is also raised. Let get this merged after than Also we can avoid using the padding for user-info. Have defined a way for it.

I agree, and also after the changes the dropdown menu has fallen into the next line

@Owaiseimdad
Copy link

Exactly @erenfn that is why I proposed to halt the pr merge here and lets continue once my PR is complete.
FYI @jasneetsingh6114 PR: #566

@erenfn
Copy link
Collaborator

erenfn commented Mar 12, 2025

Exactly @erenfn that is why I proposed to halt the pr merge here and lets continue once my PR is complete. FYI @jasneetsingh6114 PR: #566

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants