Test #2
Closed
Test #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close rust-lang#13781 The `slow_vector_initialization` lint currently only suggests using the `vec!` macro with size, but it does not suggest removing the `resize` method call. changelog: [`slow_vector_initialization`]: improve `slow_vector_initialization` suggestion
This reverts commit 09c5d34.
…t-lang#13922) I [recently realized that `.last()` might not call `next_back()` when it is available](https://qsantos.fr/2025/01/01/rust-gotcha-last-on-doubleendediterator/). Although the implementor could make sure to implement `last()` to do so, this is not what will happen by default. As a result, I think it is useful to add a lint to promote using `.next_back()` over `.last()` on `DoubleEndedIterator`. If this is merged, we might want to close rust-lang#1822. changelog: [`double_ended_iterator_last`]: Add lint for calling `Iterator::last()` on `DoubleEndedIterator`
This PR fixes two vulnerabilities in our CI, found with [zizmor](https://github.com/woodruffw/zizmor). One could be exploited by someone with tag-pushing permissions to execute arbitrary code in our CI (see`deploy.yml`). The second vulnerability would expose our tokens to a supply chain attack via a `build.rs` in one of the dependencies (See the rest of the files, and actions/checkout#485) Pre-reviewed by @flip1995 in our DMs. changelog:none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for making Clippy better!
We're collecting our changelog from pull request descriptions.
If your PR only includes internal changes, you can just write
changelog: none. Otherwise, please write a short commentexplaining your change.
It's also helpful for us that the lint name is put within backticks (
` `),and then encapsulated by square brackets (
[]), for example:If your PR fixes an issue, you can add
fixes #issue_numberinto thisPR description. This way the issue will be automatically closed when
your PR is merged.
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
.stderrfile)cargo testpasses locallycargo dev update_lintscargo dev fmtNote that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Delete this line and everything above before opening your PR.
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: