vdn: impl msg specs, support block/vote biz logic #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handler: add vdn msg handler;
handler: add vdn msg handler;
handler: fix some block/vote msg handle issues;
MatusKysel
reviewed
Mar 7, 2025
MatusKysel
reviewed
Mar 7, 2025
MatusKysel
reviewed
Mar 7, 2025
MatusKysel
reviewed
Mar 7, 2025
Comment on lines
+1
to
+32
| package vdn | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "io" | ||
|
|
||
| "github.com/ethereum/go-ethereum/rlp" | ||
| ) | ||
|
|
||
| // EncodeToStream encode any msg by rlp | ||
| func EncodeToStream(msg interface{}, writer io.Writer) error { | ||
| return rlp.Encode(writer, msg) | ||
| } | ||
|
|
||
| // DecodeFromStream msg must be a pointer | ||
| func DecodeFromStream(msg interface{}, reader io.Reader) error { | ||
| return rlp.Decode(reader, msg) | ||
| } | ||
|
|
||
| // EncodeToBytes encode any msg by rlp | ||
| func EncodeToBytes(msg interface{}) ([]byte, error) { | ||
| buf := new(bytes.Buffer) | ||
| if err := rlp.Encode(buf, msg); err != nil { | ||
| return nil, err | ||
| } | ||
| return buf.Bytes(), nil | ||
| } | ||
|
|
||
| // DecodeFromBytes msg must be a pointer | ||
| func DecodeFromBytes(msg interface{}, data []byte) error { | ||
| return rlp.DecodeBytes(data, msg) | ||
| } |
There was a problem hiding this comment.
can we use ssz? as this is complete new netwrok ssz is much better candidate encoding, if you need help with this let me know
There was a problem hiding this comment.
Yeah, it's a new network, but introducing ssz encoding is a big thing, I prefer to use current RLP encoding now. May be we can discuss this more~
MatusKysel
reviewed
Mar 7, 2025
Comment on lines
+163
to
+193
| func defaultTopicParams() *pubsub.TopicScoreParams { | ||
| decayEpoch := 5 | ||
| decayEpochDuration := 5 * oneEpochDuration() | ||
| blocksInEpoch := blocksPerEpoch() | ||
| meshWeight := -0.717 | ||
| invalidDecayPeriod := 50 * oneEpochDuration() | ||
| if !meshDeliveryIsScored { | ||
| // Set the mesh weight as zero as a temporary measure, so as to prevent | ||
| // the average nodes from being penalised. | ||
| meshWeight = 0 | ||
| } | ||
| return &pubsub.TopicScoreParams{ | ||
| TopicWeight: defaultTopicWeight, | ||
| TimeInMeshWeight: maxInMeshScore / inMeshCap(), | ||
| TimeInMeshQuantum: inMeshTime(), | ||
| TimeInMeshCap: inMeshCap(), | ||
| FirstMessageDeliveriesWeight: 1, | ||
| FirstMessageDeliveriesDecay: scoreDecay(20 * oneEpochDuration()), | ||
| FirstMessageDeliveriesCap: 23, | ||
| MeshMessageDeliveriesWeight: meshWeight, | ||
| MeshMessageDeliveriesDecay: scoreDecay(decayEpochDuration), | ||
| MeshMessageDeliveriesCap: float64(blocksInEpoch * uint64(decayEpoch)), | ||
| MeshMessageDeliveriesThreshold: float64(blocksInEpoch*uint64(decayEpoch)) / 10, | ||
| MeshMessageDeliveriesWindow: 2 * time.Second, | ||
| MeshMessageDeliveriesActivation: 4 * oneEpochDuration(), | ||
| MeshFailurePenaltyWeight: meshWeight, | ||
| MeshFailurePenaltyDecay: scoreDecay(decayEpochDuration), | ||
| InvalidMessageDeliveriesWeight: -140.4475, | ||
| InvalidMessageDeliveriesDecay: scoreDecay(invalidDecayPeriod), | ||
| } | ||
| } |
There was a problem hiding this comment.
how did you get this values? maybe some comment would be beneficial
MatusKysel
reviewed
Mar 7, 2025
MatusKysel
reviewed
Mar 7, 2025
MatusKysel
reviewed
Mar 7, 2025
MatusKysel
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements all BEP-525 msg specs, and support basic block/vote gossip msg business logic. The VDN can sync new blocks, and aggregate votes successfully now.
It also adds some abstract for gossip/RPC msg handler. see
vdn/interfaces.go.Now, you can use https://github.com/bnb-chain/node-deploy/tree/support-vdnp2p to setup a vdn-only cluster in local for testing.
Changes
Notable changes: