Update to Backbone 0.5.3 #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems more consistent with the existing folder tree and with the documentation if the 'templates' folder is under the 'app' folder.
Backbone 0.5.0+ renamed Controller to Router so I did the same everywhere it was necessary. I also moved application.coffee up to the app folder. Even it this file could have been considered as a controller, it's clearly not a router.
|
Closing as obsolete ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After adding @janmonschke fixes, I fixed issue #12 and updated Backbone to 0.5.3
As you may know, Backbone 0.5.0+ renamed "Controller" to "Router" so I did the same everywhere it was necessary.
I also moved application.coffee up to the app folder. Even it this file could have been considered as a controller, IMO it's clearly not a router.
Regards.