perf: perfect forwarding #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 22 22
Lines 1025 1025
=======================================
Hits 1022 1022
Misses 3 3
☔ View full report in Codecov by Sentry. |
bobluppes
force-pushed
the
perfect-forwarding
branch
from
ea30c5d to
debf065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not measure any significant performance improvement when building in release mode. I expect the compiler is able to optimize the redundant move construction. Nevertheless, I think perfect forwarding is still a nice to have.
add vertex benchmarks
add edge benchmarks