-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ALGO] Dijkstra Shortest Path (Tree Version) (#54) #62
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 99.80% 99.81% +0.01%
==========================================
Files 22 22
Lines 1009 1081 +72
==========================================
+ Hits 1007 1079 +72
Misses 2 2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks excellent, thanks for picking this up so quickly! Just some minor comments.
Regarding the new function not being an overload, you are correct! I slightly prefer this version with the plural paths
, but let me know if you think otherwise.
For the potential performance trade-off that you mentioned, my initial feeling is that it would not be too bad. But maybe let's add a benchmark in a follow-up and we can measure the performance impact.
Thanks, looks great! |
Please note:
dijkstra_shortest_path
as the syntax proposed in [ALGO] Dijkstra Shortest Path (Tree Version) #54 uses the pluralpaths
.