Added the negative cycle detection in bellman ford #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and relevant unit tests too.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
bobluppes
reviewed
Sep 24, 2023
Co-authored-by: Bob Luppes <[email protected]>
Co-authored-by: Bob Luppes <[email protected]>
|
Hey, Thanks for the detailed review, I have committed all the above changes. Let me know if any more changes are needed. |
bobluppes
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the #76 issue.
I have added the code for detecting a Negative cycle in Bellman Ford Shortest Path Algorithm and I have also added a unit test to test the logic in the test directory.
I did an additional pass over the edges and if there is any change detected ,An Invalid Argument exception is thrown.
"A Negative cycle has been detected in the graph".The unit test checks if this exception is thrown for a negative cycle and all the tests are passed too.