Fix issue with cross-dep bins not symlinking #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebuilds
commented
Feb 22, 2018
| @@ -63,7 +63,7 @@ export async function install(opts: InstallOptions) { | |||
| }); | |||
|
|
|||
| for (let workspace of workspaces) { | |||
| const dependencies = workspace.pkg.getAllDependencies().keys(); | |||
| let dependencies = Array.from(workspace.pkg.getAllDependencies().keys()); | |||
There was a problem hiding this comment.
This was basically the whole thing
There was a problem hiding this comment.
Do you recall what the Array.from was for here @jamiebuilds ?
jamiebuilds
commented
Feb 22, 2018
| const dest = path.join(pkg.nodeModules, dependency); | ||
| let depWorkspace = dependencyGraph.get(dependency) || {}; | ||
| let src = depWorkspace.pkg.dir; | ||
| let dest = path.join(pkg.nodeModules, dependency); |
There was a problem hiding this comment.
@lukebatchelor our battle continues
|
Moved to #191 |
|
I'll leave this branch here juuust in case I've messed something up in the rebase ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126