ADD: Support for ASGs that use the new LaunchTemplate functionality #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some guidance on fixing the tests would be appreciated. |
Mattnmoore
added a commit
to Mattnmoore/aws-amicleaner
that referenced
this pull request
Aug 15, 2018
inigo
added a commit
to 67Bricks/aws-amicleaner
that referenced
this pull request
Nov 29, 2018
…orrected to work for configurations that don't have attached launch templates too
|
Closed courtesy of inactivity. |
talset
added a commit
to cycloidio/aws-amicleaner
that referenced
this pull request
Mar 4, 2019
cameronpkeith
added a commit
to cameronpkeith/aws-amicleaner
that referenced
this pull request
Nov 13, 2020
cameronpkeith
added a commit
to cameronpkeith/aws-amicleaner
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I don't really know much Python - but I needed support for LaunchTemplates after we moved to utilise them at my day job.
Sorry if the code is rubbish - I am aware there are a few cases I've missed - I feel this stops it breaking for anyone who uses the new LaunchTemplate feature & supports LaunchTemplates as much as the LaunchConfigurations were initially.
Anyone using multiple versions of the same LaunchTemplate will have to PR themselves.
Thanks