Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase boto3 max_attempts to 10 #88

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

stolendog
Copy link
Contributor

Increase default boto3 max_attempts from 4 to 10, to have the ability to use exponential backoff when AWS API RequestLimit is reached.

botocore.exceptions.ClientError: An error occurred (RequestLimitExceeded)

@codecov-io
Copy link

Codecov Report

Merging #88 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   91.39%   91.44%   +0.05%     
==========================================
  Files          11       11              
  Lines         802      807       +5     
==========================================
+ Hits          733      738       +5     
  Misses         69       69
Impacted Files Coverage Δ
amicleaner/resources/config.py 100% <100%> (ø) ⬆️
amicleaner/fetch.py 100% <100%> (ø) ⬆️
amicleaner/core.py 84.67% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5cfe7f...9d8e5f9. Read the comment docs.

@bonclay7
Copy link
Owner

Sweet ! thanks @stolendog

@bonclay7 bonclay7 merged commit cebe632 into bonclay7:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants