Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning in the log rather than in a UI dialog. #303

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

mdoube
Copy link
Member

@mdoube mdoube commented Apr 6, 2022

Logging with LogService is intended to reduce dependence on there being a live UI, so that the wrapper can be called from a headless script more reliably.

@mdoube mdoube requested a review from alessandrofelder April 6, 2022 06:00
@mdoube
Copy link
Member Author

mdoube commented Apr 6, 2022

Should close #304

@mdoube mdoube marked this pull request as draft April 7, 2022 05:37
@mdoube mdoube marked this pull request as ready for review April 7, 2022 05:37
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mdoube mdoube merged commit 4a8b350 into master Apr 9, 2022
@mdoube mdoube deleted the logservice-warnings branch April 9, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants