Add functionality to HMM package to load and save HMMs from pickle files #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
reviewed
Jan 10, 2025
ncguilbeault
force-pushed
the
dev/hmm-load-save-from-pkl
branch
from
429b589 to
6ce9de0
Compare
ncguilbeault
force-pushed
the
dev/hmm-load-save-from-pkl
branch
from
6ce9de0 to
2545e51
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ickle` for consistency with python's pickle library.
glopesdev
reviewed
Feb 22, 2025
There was a problem hiding this comment.
Just noticed another small naming detail. In the below properties it would be nice if they can be given a standard name such as FileName.
The reason this is convenient is that it makes it possible to point a single externalized property with that name to multiple nodes, which we often do to avoid having to coordinate other more complex value passing mechanisms such as subjects.
…klFile` for consistency Co-authored-by: glopesdev <[email protected]>
glopesdev
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds functionality to the Bonsai.ML.HiddenMarkovModels package to enable HMMs to be saved to and loaded from pickle files on disk.
Changes