Move pymcubes to an optional dependency.
#310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add other packages that aren't needed for the atlasAPI? Maybe ITK is one? |
|
A quick search of this repo indicates that the following packages are only used in the
Also, we seem to be fetching Changes applied in 663bb21 |
alessandrofelder
approved these changes
Jun 14, 2024
|
brainglobe/brainglobe.github.io#203 Will also publish a new release once the tests pass on main. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
PyMCubesis a dependency that is only required during atlas generation, and currently doesn't have an ARM package on conda-forge.Forcing it to be a core dependency results in failed builds when installing via conda-forge, and since it's not needed for registration, we have decided to move it to an optional
atlasgendependency that users will not obtain by default.After this, we'll need a new PyPI release and then to fix the corresponding conda-forge feedstock PR that will be created.
What does this PR do?
Moves PyMCubes (and other altas-generation only) dependencies to an optional
atlasgendependency group.References
brainglobe/brainreg#206
How has this PR been tested?
Local
pip install -e ..Is this a breaking change?
Does this PR require an update to the documentation?
Checklist: