Skip to content

Commit

Permalink
[cr133] ChangeMetricsReportingState asks from here arg
Browse files Browse the repository at this point in the history
This information used to be defaulted to unknown, however a reason is
now required, which for the only use in the codebase fits a crash
report.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/566569a7d0d452993229638eaf139573ab7ff2b5

commit 566569a7d0d452993229638eaf139573ab7ff2b5
Author: Andrzej Sokolnicki <[email protected]>
Date:   Tue Dec 31 00:02:27 2024 -0800

    Remove kUnknown from ChangeMetricsReportingStateCalledFrom enum

    Removing placeholder enum value used also as a default state and adding correct values for the functions using that enum.

    Change-Id: Iffa4ac6fb0f4620beb9e8faa6202015792299b9c
  • Loading branch information
cdesouza-chromium committed Jan 21, 2025
1 parent 9dc41ea commit dc7f200
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion browser/ui/views/crash_report_permission_ask_dialog_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,8 @@ void CrashReportPermissionAskDialogView::OnWidgetInitialized() {

void CrashReportPermissionAskDialogView::OnAcceptButtonClicked() {
// Enable crash reporting.
ChangeMetricsReportingState(true);
ChangeMetricsReportingState(
true, ChangeMetricsReportingStateCalledFrom::kSessionCrashedDialog);
}

void CrashReportPermissionAskDialogView::OnWindowClosing() {
Expand Down

0 comments on commit dc7f200

Please sign in to comment.