Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message): revert 'Add Flag Support' (#264) #296

Conversation

shellcromancer
Copy link
Contributor

Description

This reverts commit 1acc9a0 and follow-up changes. We've observed this not correctly skipping missing values before with sparsely populated datasets. This results in many null values

Motivation and Context

We observed a data quality regression from the v2.2+ releases stemming from value skipping. This reverts those changes to address that.

How Has This Been Tested?

This playground link does not work with the changes but now correctly transforms when a missing value is inspected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@shellcromancer shellcromancer force-pushed the dstinson-diess/secops-245-fix-inconsistent-skipmissingvalues-behavior-in-substation branch from ed52340 to fb271d2 Compare March 3, 2025 22:08
@shellcromancer shellcromancer changed the title Revert "feat(message): Add Flag Support (#264)" fix(message): revert 'Add Flag Support' (#264) Mar 3, 2025
@shellcromancer shellcromancer marked this pull request as ready for review March 3, 2025 22:12
@shellcromancer shellcromancer requested a review from a team as a code owner March 3, 2025 22:12
@shellcromancer shellcromancer merged commit 972df08 into main Mar 4, 2025
8 checks passed
@shellcromancer shellcromancer deleted the dstinson-diess/secops-245-fix-inconsistent-skipmissingvalues-behavior-in-substation branch March 4, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants