build.rs: Use cc-rs in a more canonical way in most cases. #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1699 +/- ##
=======================================
Coverage 96.05% 96.06%
=======================================
Files 135 135
Lines 20521 20521
Branches 217 217
=======================================
+ Hits 19712 19713 +1
Misses 771 771
+ Partials 38 37 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Oct 6, 2023
briansmith
force-pushed
the
b/simplify-build.rs-2
branch
from
78ebbd4 to
0bd777e
Compare
|
@NobodyXu WDYT about this, in light of #1591 (comment)? Do you think this is good to check in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit comments. The intent here is to help people understand what's required to adapt build.rs to an alternative build system by making its use of cc-rs more idiomatic.