Assert HTTP inputs work in CWL #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure what's gone wrong but Travis is not happy... |
cjllanwarne
force-pushed
the
cjl_http_inputs_test
branch
from
19ca4cf to
ce5d44b
Compare
cjllanwarne
added
<=== READY FOR REVIEW !!!
and removed
Don't Look At Me 🙈
mcovarr
approved these changes
Nov 19, 2018
| @@ -13,7 +13,18 @@ Support `InputResourceRequirement` hint | |||
|
|
|||
| ### Changing configuration options | |||
|
|
|||
| When the value `exit-code-timeout-seconds` is set, `check-alive` command is now only called once every timeout interval instead of each poll. | |||
| - The HTTP filesystem is now enabled for engine use by default. To continue without an HTTP filesystem, you can add the | |||
| following content into the appropriate stanza of your configuration file: | |||
kshakir
approved these changes
Nov 20, 2018
| @@ -126,7 +126,7 @@ class MaterializeWorkflowDescriptorActorSpec extends CromwellTestKitWordSpec wit | |||
| wfDesc.knownValues.head._2 shouldBe WomInteger(5) | |||
| wfDesc.getWorkflowOption(WorkflowOptions.WriteToCache) shouldBe None | |||
| wfDesc.getWorkflowOption(WorkflowOptions.ReadFromCache) shouldBe None | |||
| wfDesc.pathBuilders.size shouldBe 1 | |||
| wfDesc.pathBuilders.size shouldBe 2 // // one each for the local and http filesystems | |||
There was a problem hiding this comment.
2 // // one should be 2 // one
There was a problem hiding this comment.
To avoid travis re-runs, I'll address this is my part II, (stable(r) names for HTTP inputs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to ensure HTTP inputs also work in CWL