-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace watcher.js with broccoli-sane-watcher. #163
Replace watcher.js with broccoli-sane-watcher. #163
Conversation
nice! |
I think... there might be a bug in the watcher. We should confirm, if it is the case I imagine it wont be hard to fix. |
broccoli-sane-watcher has been updated. |
As another data point of this vs Chokidar:
|
That's a TODO, I'm not using the ready event yet, either outputing to the user that it is now in fact watching, or double checking that the tree is still the same as when it was added. |
I had planned broccoli-sane-watcher to become a PR for broccoli, not for broccoli to depend on it. Right now that is circular, since broccoli-sane-watcher depends on broccoli for printSlowTrees. If we go this route, printSlowTrees should be a module, and watching should be more pluggable with broccoli. /cc @joliss @stefanpenner |
@krisselden i'll extract the logging for you -> broccolijs/broccoli-sane-watcher#5 (assigned myself) |
@joliss should this be closed? You have a different plan for integration of broccoli-sane-watcher, confirm? |
@krisselden ya i believe she does. |
Replaces watcher.js with @krisselden's broccoli-sane-watcher
Should resolve #72 and replace #150
On our largish ember.js project we went from consistent 25% cpu with current watcher to roughly 0% using the sane-watcher
cc: @stefanpenner @rondale-sc @krisselden