Allow URLs with relative protocol #32
Conversation
Unfortunately filter_var() rejects valid URLs like "//example.org", so we now only reject empty URLs and URLs which are seriously malformed.
There was a problem hiding this comment.
@mbrodala Thanks for your contribution. However, I have a remark.
|
TBH I wonder if only rejecting an empty value is enough. Everything else is up to the integrator/developer IMO. If you set an invalid URL, you should be aware of that. |
|
I added the check to avoid a "url" which isn't one but does something bad in the JS code. So it should look at least like a URL. I am aware that ftp://example.com is also valid by the check. But that won't open a possible security issue but just doesn't work. The value comes from outside and cannot be trusted. |
|
@mbrodala Thanks for your contribution: I added the feature to the latest release 2.3.0: |
This allows the
matomoIntegrationUrlto use a relative protocol, e.g.//example.org. This is in line with the sitebasewhich also allows this.