[TEST] Gov parameter acessors #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using GetParameter. Add logic to utility module to convert string parameters to []byte types. Update unit tests
17 tasks
bryanchriswhite
added a commit
to pokt-network/pocket
that referenced
this pull request
Jan 27, 2023
## Description While recent update to changelog verification works as expected when run locally, it seems to consistently return a false positive result when running in GitHub actions. Testing @h5law's [hypothesis](https://discordapp.com/channels/553741558869131266/986789914379186226/1067940783111544952) (i.e. maybe `HEAD` or `main` aren't what we expect them to be in that environment). TLDR; we probably shouldn't rely on git refs in this context. This PR addresses fixes this false positive scenario as well as cleans up a bit. ## Issue No issue as of time of writing, see: https://discordapp.com/channels/553741558869131266/986789914379186226/1067940783111544952 ## Type of change Please mark the relevant option(s): - [ ] New feature, functionality or library - [x] Bug fix - [x] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other <!-- add details here if it a different type of change --> ## List of changes - Rename pre-push to pre-receive: `pre-push` conventionally receives 2 arguments (remote and url), which aren't useful for our case; additionally, `pre-receive` is a better conceptual fit for the purpose it serves - Receive list of changed files as argument instead of trying to compute in the same script - Add quotes around changed files variable interpolation ## Testing - [ ] `make develop_test` - [ ] [LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md) w/ all of the steps outlined in the `README` - [x] Tested via [PR to my fork](bryanchriswhite#3) ## Required Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have tested my changes using the available tooling - [ ] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s) --------- Co-authored-by: harry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
Fixes #<issue_number>
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_testREADMERequired Checklist
If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)