btcec: validate R and S signature components in RecoverCompact #1691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent panic in
btcec.RecoverCompact
by validating signature components. We check ifr
ands
values are:The
RecoverCompact
algorithm relies on a multiplicative inverse of ther
value. The panic in #1651 was due to the fact that ther
value (i.e., x-coordinate of random pointR
) was0
. Such a point does not lie on the secp256k1 curve either, making the signature invalid.