Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wire.Outpoint parser from string #1879

Merged
merged 2 commits into from
May 25, 2023

Conversation

GeorgeTsagk
Copy link
Contributor

  • Adds NewOutPointFromString function in wire package.
  • Adds unit tests for NewOutPointFromString

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! Definitely nice to have that in the wire package directly.

@GeorgeTsagk GeorgeTsagk force-pushed the wire/outpoint-parse-string branch from 4c153dc to f8e43ca Compare August 16, 2022 15:13
@GeorgeTsagk GeorgeTsagk requested a review from guggero August 16, 2022 15:13
@GeorgeTsagk
Copy link
Contributor Author

@guggero
Also added a new test case named big index outpoint, which includes a tx index which is a bit higher than the max int32 value.

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@GeorgeTsagk GeorgeTsagk force-pushed the wire/outpoint-parse-string branch from f8e43ca to ca133a4 Compare August 17, 2022 15:25
@GeorgeTsagk GeorgeTsagk requested a review from bhandras August 17, 2022 15:25
Copy link
Contributor

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small nits remain, otherwise LGTM 🎉

@GeorgeTsagk GeorgeTsagk force-pushed the wire/outpoint-parse-string branch from ca133a4 to d827d02 Compare August 17, 2022 16:22
@coveralls
Copy link

coveralls commented Aug 18, 2022

Pull Request Test Coverage Report for Build 2868576184

  • 13 of 17 (76.47%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 55.143%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wire/msgtx.go 13 17 76.47%
Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 81.25%
Totals Coverage Status
Change from base Build 2836573928: 0.01%
Covered Lines: 26533
Relevant Lines: 48117

💛 - Coveralls

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

@Roasbeef Roasbeef merged commit 9c16d23 into btcsuite:master May 25, 2023
@coveralls
Copy link

coveralls commented Nov 30, 2024

Pull Request Test Coverage Report for Build 2876839350

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 17 (76.47%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 55.139%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wire/msgtx.go 13 17 76.47%
Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 81.25%
Totals Coverage Status
Change from base Build 2836573928: 0.01%
Covered Lines: 26531
Relevant Lines: 48117

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants