Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump golang base image version to 1.17 #1882

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

tochicool
Copy link
Contributor

Image fails to build on the current 1.16 tag with the error:

> docker build . --build-arg ARCH=amd64
...
btcd.go:21:2: //go:build comment without // +build comment
The command '/bin/sh -c set -ex   && if [ "${ARCH}" = "amd64" ]; then export GOARCH=amd64; fi   && if [ "${ARCH}" = "arm32v7" ]; then export GOARCH=arm; fi   && if [ "${ARCH}" = "arm64v8" ]; then export GOARCH=arm64; fi   && echo "Compiling for $GOARCH"   && go install -v . ./cmd/...' returned a non-zero code: 1

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2984473967

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+16.7%) to 71.86%

Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 81.25%
Totals Coverage Status
Change from base Build 2836573928: 16.7%
Covered Lines: 12753
Relevant Lines: 17747

💛 - Coveralls

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit 38ee9a4 into btcsuite:master Sep 13, 2022
@coveralls
Copy link

coveralls commented Nov 30, 2024

Pull Request Test Coverage Report for Build 2984473967

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 55.131%

Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 81.25%
Totals Coverage Status
Change from base Build 2836573928: 0.002%
Covered Lines: 26518
Relevant Lines: 48100

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants