musig2: fix early nonce gen option #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5519660551
💛 - Coveralls |
Roasbeef
reviewed
Jul 10, 2023
btcec/schnorr/musig2/context.go
Outdated
| default: | ||
| return nil, ErrSignersNotSpecified | ||
| } | ||
|
|
||
| // If early nonce generation is specified, then we'll generate |
There was a problem hiding this comment.
Ah I guess my previous use case always had the number of signers specified (case of LN channel funding).
sputn1ck
force-pushed
the
musig2_fix_early_nonce_gen
branch
2 times, most recently
from
39ec882 to
ff0d41d
Compare
I adapted the early nonce gen test to use both ways of creating a context. Can also add a completely new unit test if preferred. |
Previously the early nonce generation option was not being respected when creating the context, with the WithKnownSigners option being used. This commit fixes that.
This commit changes the early nonce gen test to use the KnownSigners Option for one of the contexts.
sputn1ck
force-pushed
the
musig2_fix_early_nonce_gen
branch
from
ff0d41d to
883a03d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the early nonce generation option was not being respected when creating the context, with the
WithKnownSignersoption being used.