-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add testnet4 chain support (recreated) #2318
base: master
Are you sure you want to change the base?
feat: Add testnet4 chain support (recreated) #2318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Definitely looks better now.
Have a couple of fixes that are required, otherwise things crash quite immediately (please test things before requesting review in the future).
After those fixes I was able to sync up to block height 70513
hey @bullet-tooth are you planning to work on this pr at a high priority? We are interested in moving this along quickly. Thanks. |
Done. Also, verified locally, it could sync up to the current height (71627). |
Pull Request Test Coverage Report for Build 13524296390Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if you could squash/fixup the last 4 commits into those that actually introduced the code (to make it easy for the next reviewer, see https://thoughtbot.com/blog/git-interactive-rebase-squash-amend-rewriting-history).
Other than that looks good to me, thanks!
Need a second reviewer though.
738e87f
to
6f8d6a0
Compare
This PR is a recreation of the previous PR because I incidentally dropped a brunch and the PR was closed automatically.
Description
This PR adds support of the Bitcoin testnet version 4 chain (testnet3 is in a way of deprecation).
Reference: https://bips.dev/94/
Testnet4 genesis block: https://mempool.space/testnet4/block/00000000da84f2bafbbc53dee25a72ae507ff4914b867c565be350b0da8bf043