Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix ci / makefile #2320

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat: fix ci / makefile #2320

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
503393f
replace goacc with built-in coverage tool
rabbitprincess Feb 11, 2025
8ae9510
remove tidy script
rabbitprincess Feb 11, 2025
49023e0
fix lint
rabbitprincess Feb 11, 2025
bdde689
remove unnecessary define
rabbitprincess Feb 11, 2025
3228412
fix goimports
rabbitprincess Feb 11, 2025
2a1e3f5
remove DEPGET
rabbitprincess Feb 11, 2025
c7d9734
Makefile: use common variable
rabbitprincess Feb 11, 2025
a45f028
Makeifle: remove GOFILES_NOVENDOR
rabbitprincess Feb 12, 2025
d6b769f
update workflows action version
rabbitprincess Feb 12, 2025
3403e93
fix import and fmt using make fmt
rabbitprincess Feb 12, 2025
bdf7318
makefile: remove issues-exit-code=0
rabbitprincess Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ GOTEST_DEV = go test -v -tags=$(DEV_TAGS)
GOTEST := go test -v
GOMODTIDY := go mod tidy

GOFILES_NOVENDOR = $(shell find . -type f -name '*.go' -not -path "./vendor/*")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 it's been years since we vendor'd deps


# Linting uses a lot of memory, so keep it under control by limiting the number
# of workers if requested.
ifneq ($(workers),)
Expand Down Expand Up @@ -89,9 +87,9 @@ check: unit
unit:
@$(call print, "Running unit tests.")
$(GOTEST_DEV) ./... -test.timeout=20m
cd btcec; $(GOTEST_DEV) ./... -test.timeout=20m
cd btcutil; $(GOTEST_DEV) ./... -test.timeout=20m
cd btcutil/psbt; $(GOTEST_DEV) ./... -test.timeout=20m
cd btcec && $(GOTEST_DEV) ./... -test.timeout=20m
cd btcutil && $(GOTEST_DEV) ./... -test.timeout=20m
cd btcutil/psbt && $(GOTEST_DEV) ./... -test.timeout=20m

#? unit-cover: Run unit coverage tests
unit-cover:
Expand All @@ -100,17 +98,17 @@ unit-cover:

# We need to remove the /v2 pathing from the module to have it work
# nicely with the CI tool we use to render live code coverage.
cd btcec; $(GOTEST) -coverprofile=coverage.txt ./...; sed -i.bak 's/v2\///g' coverage.txt
cd btcutil; $(GOTEST) -coverprofile=coverage.txt ./...
cd btcutil/psbt; $(GOTEST) -coverprofile=coverage.txt ./...
cd btcec && $(GOTEST) -coverprofile=coverage.txt ./... && sed -i.bak 's/v2\///g' coverage.txt
cd btcutil && $(GOTEST) -coverprofile=coverage.txt ./...
cd btcutil/psbt && $(GOTEST) -coverprofile=coverage.txt ./...

#? unit-race: Run unit race tests
unit-race:
@$(call print, "Running unit race tests.")
env CGO_ENABLED=1 GORACE="history_size=7 halt_on_errors=1" $(GOTEST) -race -test.timeout=20m ./...
cd btcec; env CGO_ENABLED=1 GORACE="history_size=7 halt_on_errors=1" $(GOTEST) -race -test.timeout=20m ./...
cd btcutil; env CGO_ENABLED=1 GORACE="history_size=7 halt_on_errors=1" $(GOTEST) -race -test.timeout=20m ./...
cd btcutil/psbt; env CGO_ENABLED=1 GORACE="history_size=7 halt_on_errors=1" $(GOTEST) -race -test.timeout=20m ./...
cd btcec && env CGO_ENABLED=1 GORACE="history_size=7 halt_on_errors=1" $(GOTEST) -race -test.timeout=20m ./...
cd btcutil && env CGO_ENABLED=1 GORACE="history_size=7 halt_on_errors=1" $(GOTEST) -race -test.timeout=20m ./...
cd btcutil/psbt && env CGO_ENABLED=1 GORACE="history_size=7 halt_on_errors=1" $(GOTEST) -race -test.timeout=20m ./...

# =========
# UTILITIES
Expand All @@ -119,9 +117,9 @@ unit-race:
#? fmt: Fix imports and formatting source
fmt: goimports
@$(call print, "Fixing imports.")
$(GOIMPORTS_BIN) -w $(GOFILES_NOVENDOR)
$(GOIMPORTS_BIN) -w .
@$(call print, "Formatting source.")
gofmt -l -w -s $(GOFILES_NOVENDOR)
gofmt -l -w -s .

#? lint: Lint source
lint: $(LINT_BIN)
Expand All @@ -137,9 +135,9 @@ clean:
tidy-module:
@$(call print, "Running 'go mod tidy' for all modules")
$(GOMODTIDY)
cd btcec; $(GOMODTIDY)
cd btcutil; $(GOMODTIDY)
cd btcutil/psbt; $(GOMODTIDY)
cd btcec && $(GOMODTIDY)
cd btcutil && $(GOMODTIDY)
cd btcutil/psbt && $(GOMODTIDY)

.PHONY: all \
default \
Expand Down