Modify default account naming policy. #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
force-pushed
the
jrick_default_account_name
branch
2 times, most recently
from
e413e39 to
946ae44
Compare
Closed
jrick
force-pushed
the
jrick_default_account_name
branch
2 times, most recently
from
3ad8e17 to
09769e7
Compare
|
rebased |
| } | ||
| ) | ||
| // isReservedAccountName returns true if the account name is reserved. Reserved | ||
| // accounts may never be renamed, and other account may not be renamed to a |
|
Other than the accounts typo and conversion to *btjcjson.RPCError which you did while I was reviewing, looks good. OK after that typo fix and squash. I'll merge btcsuite/btcd#399 as well. It's ready too. |
|
Travis will fail this one since btcsuite/btcd#399 isn't in yet. |
jrick
force-pushed
the
jrick_default_account_name
branch
from
ccb8911 to
ec6034e
Compare
Rather than disallowing the default account to be renamed as was proposed in btcsuite#245 (and implemented in btcsuite#246), the default account name is no longer considered a reserved name by the address manager. Instead, it is simply the initial name used for the first initial account. A database upgrade removes any additional aliases for the default account in the database. This prevents a lookup for some name which is not an account name from mapping to the default account unexpectedly (potentially preventing incorrect account usage from the RPC server due to bad iteraction with default parameters). All unset account names in a JSON-RPC request are expected to be set nil by btcjson. This behavior depends on btcsuite/btcd#399. Additionally, the manager no longer considers the wildcard * to be a reserved account name. Due to poor API decisions, the RPC server overloads the meaning of account fields to optionally allow referring to all accounts at a time, or a single account. This is not a address manager responsibility, though, as a future cleaner API should not use multiple differet meanings for the same field across multiple requests. Therefore, don't burden down future APIs with this quirk and prevent incorrect wildcard usage from the RPC server. Closes btcsuite#245.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be merged together with btcsuite/btcd#399.