Removing BCF API OAuth2 specifics #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided to reference the official OAuth2 specification to indicate that the BCF API does not deviate from the regular OAuth2 specification. The authorization code flow has been moved to an example file.
This was referenced Dec 22, 2016
Closed
jasollien
reviewed
Dec 22, 2016
|
|
||
| **Parameters** | ||
|
|
||
| |Parameter|Type|Description|Required| | ||
| |---------|----|-----------|--------| | ||
| |oauth2_auth_url|string|URL to authorisation page|false| | ||
| |oauth2_auth_url|string|URL to authorisation page (used for Authorization Code Grant and Implicit Grant OAuth2 flows)|false| |
There was a problem hiding this comment.
authorisation --> authorization.
jasollien
reviewed
Dec 22, 2016
| * `resource_owner_password_credentials_grant` - [4.3 - Resource Owner Password Credentials Grant](https://tools.ietf.org/html/rfc6749#section-4.3) | ||
| * `extension_grants` - [4.5 - Extension Grants](https://tools.ietf.org/html/rfc6749#section-4.5) | ||
|
|
||
| The [OAuth2 Client Credentials Grant (section 4.4)](https://tools.ietf.org/html/rfc6749#section-4.4) is not supported since it does not contain an user identity. |
jasollien
reviewed
Dec 22, 2016
| * `authorization_code_grant` - [4.1 - Authorization Code Grant](https://tools.ietf.org/html/rfc6749#section-4.1) | ||
| * `implicit_grant` - [4.2 - Implicit Grant](https://tools.ietf.org/html/rfc6749#section-4.2) | ||
| * `resource_owner_password_credentials_grant` - [4.3 - Resource Owner Password Credentials Grant](https://tools.ietf.org/html/rfc6749#section-4.3) | ||
| * `extension_grants` - [4.5 - Extension Grants](https://tools.ietf.org/html/rfc6749#section-4.5) |
There was a problem hiding this comment.
I am not 100% sure how this flow works. Have you verified that it fit our needs?
jasollien
reviewed
Dec 22, 2016
| "null"], | ||
| "items": { | ||
| "type": ["string"] | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you add a newline at the end of the file?
|
Made a few comments. The rest looks gode. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to reference the official OAuth2 specification to indicate that the BCF API does not deviate from the regular OAuth2 specification. The authorization code flow has been moved to an example file.