Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Download PDF from Spreadsheet #1035 #1036

Merged
merged 3 commits into from
Apr 27, 2022
Merged

feat: Download PDF from Spreadsheet #1035 #1036

merged 3 commits into from
Apr 27, 2022

Conversation

100paperkite
Copy link
Contributor

@100paperkite 100paperkite commented Apr 24, 2022 •
edited by lavigne958
Loading

Add feature to export a spreadsheet to a PDF

And I have some questions about...

  • Supporting to export a spreadsheet to other types of files (for all file types listed in Google API docs)
  • Writing test for exporting ( How should I write test for export? )

closes #1035

@lavigne958 lavigne958 self-requested a review April 26, 2022 08:31
lavigne958
lavigne958 reviewed Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this improvement.
There is only a minor detail to change then this is ready to merge.

@100paperkite
Copy link
Contributor Author

Thanks for the review! I updated PR

@lavigne958 lavigne958 merged commit 80526d2 into burnash:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavigne958 lavigne958 lavigne958 left review comments

Assignees

@100paperkite 100paperkite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download PDF from Spreadsheet
2 participants
@100paperkite @lavigne958