Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

700-fill-merged-cells #1215

Merged
merged 13 commits into from
Jun 14, 2023
Merged

700-fill-merged-cells #1215

merged 13 commits into from
Jun 14, 2023

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Jun 8, 2023

Implement feature suggestion from #700:

" Same value for all merged cells "

This is added as an optional (default off) feature of Worksheet.get_values

I would have edited #741 but it was very old so hard to edit without a git mess.

closes #700
closes #741

this is probably not done in the best way. I use an extra API request where I should perhaps just use the internal Worksheet._properties object. I can change this if requested.

note: this could also be implemented for Worksheet.row_values and Worksheet_get, but I did not do so, because I did not want to play with ValueRange...

@alifeee alifeee requested a review from lavigne958 June 8, 2023 19:04
Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feature it has been waiting for so long.

I only have a couple of comments

Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same value for all merged cells
2 participants