Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dictionary credentials auth #860

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

dmytrostriletskyi
Copy link
Contributor

@dmytrostriletskyi dmytrostriletskyi commented Apr 16, 2021

Hello,

the library provides two methods of auth: service_account and service_account_from_dict. service_account_from_dict was added last year in this pull request, but wasn't documented. At least, I have not found anything:

Screenshot 2021-04-16 at 12 07 46

So, this pull requests adds some documentation for the service_account_from_dict function to auth using service account documentation section. I have built it locally, it looks like:

Screenshot 2021-04-16 at 12 19 59

If there is something I should add, just tell me. Thank you in advance! :)

@burnash burnash merged commit 810183b into burnash:master Apr 16, 2021
@burnash
Copy link
Owner

burnash commented Apr 16, 2021

Brilliant! Thank you very much! Kudos for the screenshot of the final result :)

@lavigne958 lavigne958 added this to the 3.8.0 milestone Jul 8, 2021
@lavigne958 lavigne958 modified the milestones: 3.8.0, 4.0.0 Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants