Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more flake8 tests #917

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Add more flake8 tests #917

merged 1 commit into from
Aug 29, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 28, 2021

Now that we have run black and isort, most flake8 tests pass.

This PR makes minor changes so that flake8 tests all pass except one that is incompatible with black.

Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

I just have a few questions.

Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lavigne958 lavigne958 merged commit d2a7a49 into burnash:master Aug 29, 2021
@cclauss cclauss deleted the flake8 branch August 29, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants