Bugfix/fix protected range user emails list #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain why the parameter `editor_users_emails` is mandatory now, explain that the owner of the spreadsheet will always be part of the editor users email list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
current implementation adds all the email addresses with any kind of access (read, write) as editor of a protected range.
A protected range is a range where only a subset of the email addresses with a write access can edit.
Bugfix
simply add any given email address from the user, if the address does not have write access, if the address does not exists, etc this is in charge of the user to handle.
Update docstring for the user to clearly understand what is expected and any side effects.